Skip to main content

Please review: fix of issue #6 (OTA provisioning for exported tests)

9 replies [Last post]
Anonymous

Guys,

Please review new update which adds a simple HTTP server for OTA
provisioning of exported tests:

http://fisheye4.cenqua.com/changelog/cqme/?cs=718

Thanks,
Dmitri.

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Vladimir Sizikov

Alexander,

Please add this to your reviews queue, I'm fully booked now.

Dmitry, only one question from me. I see the JarBuilder changes, (with
lots of good javadocs too!). Did Stan approve the change, or what's
the status of this? (I might be missed some of the emails).

Thanks,
--Vladimir

On Mon, Apr 23, 2007 at 01:39:02PM +0400, Dmitri Trounine wrote:
> Guys,
>
> Please review new update which adds a simple HTTP server for OTA
> provisioning of exported tests:
>
> http://fisheye4.cenqua.com/changelog/cqme/?cs=718
>
> Thanks,
> Dmitri.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Alexander Alexeev

Hi Dmitri,

sorry for delay, the overall changes look good. First, some minor code's
comments:
1) Several unused imports and variables in ProvisioningServer.java.
2) DEFAULT_PROVISIONING_HTTP_PORT variable in ExportBundler.java is
never used.
3) Is it really needed to provide empty classpath in
"dist-provisioning_server.jar" task?
4) provisioningServerMainClass.mf file doesn't contain newline at end.
Some programs treat such files as binary (for example teamware). I think
it's better to add newline.
5) I noticed you removed dependencies from run tasks. Are they really
don't depend to another tasks now?
6) Did Stan approved changes in JarBuilder.java?

Now the runtime comments. I tried the server in work:
1) "preverify" task fails due to absence of MultiTest.
2) some task requires javatest.jar located in the test suite's lib
directory.
3) starting of server fails due to absence "provisioning.http.port"
property.
4) the message:
[java] Connection failure. Retrying.
appears during server startup.

Thanks,
Alexander

Vladimir Sizikov wrote:
> Alexander,
>
> Please add this to your reviews queue, I'm fully booked now.
>
> Dmitry, only one question from me. I see the JarBuilder changes, (with
> lots of good javadocs too!). Did Stan approve the change, or what's
> the status of this? (I might be missed some of the emails).
>
> Thanks,
> --Vladimir
>
> On Mon, Apr 23, 2007 at 01:39:02PM +0400, Dmitri Trounine wrote:
>> Guys,
>>
>> Please review new update which adds a simple HTTP server for OTA
>> provisioning of exported tests:
>>
>> http://fisheye4.cenqua.com/changelog/cqme/?cs=718
>>
>> Thanks,
>> Dmitri.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
>> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Dmitri Trounine

Hi Alexander,

Thank you much for review. See my comments below:

Alexander Alexeev wrote:
> Hi Dmitri,
>
> sorry for delay, the overall changes look good. First, some minor code's
> comments:
> 1) Several unused imports and variables in ProvisioningServer.java.
Fixed.
> 2) DEFAULT_PROVISIONING_HTTP_PORT variable in ExportBundler.java is
> never used.
Fixed. Using it for settin provisioning.http.port in case it cannot be
obtained from JAR URL prefix.
> 3) Is it really needed to provide empty classpath in
> "dist-provisioning_server.jar" task?
Yes, it's required attribute of create_j2se_jar macro. Build fails
without it.
> 4) provisioningServerMainClass.mf file doesn't contain newline at end.
> Some programs treat such files as binary (for example teamware). I think
> it's better to add newline.
Fixed.
> 5) I noticed you removed dependencies from run tasks. Are they really
> don't depend to another tasks now?
I've removed dependencies from run-remote and run-test targets. It's
made because they are called from 'run' target.
They need to be called using 'antcacall' task because they should run in
parallel. When target is called using 'antcall' task, all its
dependencies are executed, even if they were already executed as
dependencies of parent target. As result, if we keep dependencies in
'run-remote' and 'run-test', all dependencies are executed three times!
So, I removed dependencies from 'run-test' and 'run-remote' and kept
them in 'run'.

> 6) Did Stan approved changes in JarBuilder.java?
No, changes in JarBuilder is a subject of issue #90, and Stan didn't yet
approved it. In fact, after sending this update for review I removed fix
of JarBuilder, so that it's now unchanged. You can verify this at the
follwoing link which shows the changes made in JarBuilder from the rev.
717 (when the branch was created) to the rev. 789 (HEAD):

http://fisheye4.cenqua.com/browse/cqme/branches/users/dtrounine/testExpo...
>
> Now the runtime comments. I tried the server in work:
> 1) "preverify" task fails due to absence of MultiTest.
Issue #79: Bad JarBuilder => agent_client.jar is added from within the
private methods => no way to catch it and add the sources => no
MultiTest => build fails.
Beacause of this I needed to apply fix to JarBuilder from another branch
and then forgot to remove it. :)
If you want to test the runtime, please do the following
- checkout branch
- apply fix to local workspace:
svn merge -r 609:HEAD
https://cqme.dev.java.net/svn/cqme/branches/users/dtrounine/testExport/i...
> 2) some task requires javatest.jar located in the test suite's lib
> directory.
This task is 'run-remote'. It starts the remote component in JTHarness
in batch mode.
> 3) starting of server fails due to absence "provisioning.http.port"
> property.
User should define this property in build.properties. This will be
mentioned in more info for "Jar URL Prefix" question of interview (issue
#45 is about updating more info, and i'm working on it).
I'll also add a check of this property to build.
> 4) the message:
> [java] Connection failure. Retrying.
> appears during server startup.
I've also observed such messages, but they never caused a problem -
server starts always. I'll file an issue about this message.

Please see new update:
http://fisheye4.cenqua.com/changelog/cqme/branches/users/dtrounine/testE...

I've also merged latest update from trunk to this branch with some bug
fixes (just some useful bugfixes):
http://fisheye4.cenqua.com/changelog/cqme/branches/users/dtrounine/testE...

Thanks,
Dmitri.

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Alexander Alexeev

Hi Dmitri,

I'm OK with code's changes. See some comments below.

>> 2) some task requires javatest.jar located in the test suite's lib
>> directory.
> This task is 'run-remote'. It starts the remote component in JTHarness
> in batch mode.
I mean javatest.jar is required to be located in test suite's lib dir.
Is it possible to require javetest.jar in the lib dir of JTHarness
installation?
>> 4) the message:
>> [java] Connection failure. Retrying.
>> appears during server startup.
> I've also observed such messages, but they never caused a problem -
> server starts always. I'll file an issue about this message.
Do we have a short deadline for this feature? If no I think more
preferable to fix this issue or find a cause at least.

Thanks,
Alexander

Dmitri Trounine wrote:
> Hi Alexander,
>
> Thank you much for review. See my comments below:
>
> Alexander Alexeev wrote:
>> Hi Dmitri,
>>
>> sorry for delay, the overall changes look good. First, some minor code's
>> comments:
>> 1) Several unused imports and variables in ProvisioningServer.java.
> Fixed.
>> 2) DEFAULT_PROVISIONING_HTTP_PORT variable in ExportBundler.java is
>> never used.
> Fixed. Using it for settin provisioning.http.port in case it cannot be
> obtained from JAR URL prefix.
>> 3) Is it really needed to provide empty classpath in
>> "dist-provisioning_server.jar" task?
> Yes, it's required attribute of create_j2se_jar macro. Build fails
> without it.
>> 4) provisioningServerMainClass.mf file doesn't contain newline at end.
>> Some programs treat such files as binary (for example teamware). I think
>> it's better to add newline.
> Fixed.
>> 5) I noticed you removed dependencies from run tasks. Are they really
>> don't depend to another tasks now?
> I've removed dependencies from run-remote and run-test targets. It's
> made because they are called from 'run' target.
> They need to be called using 'antcacall' task because they should run in
> parallel. When target is called using 'antcall' task, all its
> dependencies are executed, even if they were already executed as
> dependencies of parent target. As result, if we keep dependencies in
> 'run-remote' and 'run-test', all dependencies are executed three times!
> So, I removed dependencies from 'run-test' and 'run-remote' and kept
> them in 'run'.
>
>> 6) Did Stan approved changes in JarBuilder.java?
> No, changes in JarBuilder is a subject of issue #90, and Stan didn't yet
> approved it. In fact, after sending this update for review I removed fix
> of JarBuilder, so that it's now unchanged. You can verify this at the
> follwoing link which shows the changes made in JarBuilder from the rev.
> 717 (when the branch was created) to the rev. 789 (HEAD):
>
> http://fisheye4.cenqua.com/browse/cqme/branches/users/dtrounine/testExpo...
>
>>
>> Now the runtime comments. I tried the server in work:
>> 1) "preverify" task fails due to absence of MultiTest.
> Issue #79: Bad JarBuilder => agent_client.jar is added from within the
> private methods => no way to catch it and add the sources => no
> MultiTest => build fails.
> Beacause of this I needed to apply fix to JarBuilder from another branch
> and then forgot to remove it. :)
> If you want to test the runtime, please do the following
> - checkout branch
> - apply fix to local workspace:
> svn merge -r 609:HEAD
> https://cqme.dev.java.net/svn/cqme/branches/users/dtrounine/testExport/i...
>
>> 2) some task requires javatest.jar located in the test suite's lib
>> directory.
> This task is 'run-remote'. It starts the remote component in JTHarness
> in batch mode.
>> 3) starting of server fails due to absence "provisioning.http.port"
>> property.
> User should define this property in build.properties. This will be
> mentioned in more info for "Jar URL Prefix" question of interview (issue
> #45 is about updating more info, and i'm working on it).
> I'll also add a check of this property to build.
>> 4) the message:
>> [java] Connection failure. Retrying.
>> appears during server startup.
> I've also observed such messages, but they never caused a problem -
> server starts always. I'll file an issue about this message.
>
> Please see new update:
> http://fisheye4.cenqua.com/changelog/cqme/branches/users/dtrounine/testE...
>
>
> I've also merged latest update from trunk to this branch with some bug
> fixes (just some useful bugfixes):
> http://fisheye4.cenqua.com/changelog/cqme/branches/users/dtrounine/testE...
>
>
> Thanks,
> Dmitri.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Dmitri Trounine

Alexander,

Thanks for review! Let finish with this update :) See my comment below

Alexander Alexeev wrote:
> Hi Dmitri,
>
> I'm OK with code's changes. See some comments below.
>
> >> 2) some task requires javatest.jar located in the test suite's lib
> >> directory.
> > This task is 'run-remote'. It starts the remote component in JTHarness
> > in batch mode.
> I mean javatest.jar is required to be located in test suite's lib dir.
> Is it possible to require javetest.jar in the lib dir of JTHarness
> installation?
> >> 4) the message:
> >> [java] Connection failure. Retrying.
> >> appears during server startup.
> > I've also observed such messages, but they never caused a problem -
> > server starts always. I'll file an issue about this message.
> Do we have a short deadline for this feature? If no I think more
> preferable to fix this issue or find a cause at least.
>
Deadline was yesterday. And there are so many issues to fix. While fixes
are pending, the complexity multiplies. This issue is really not
critical. I've investigated a little this problem: looks like exception
is thrown from HttpServer code at startup. May I file a new issue and
commit?

Thanks,
Dmitri.
> Thanks,
> Alexander
>
> Dmitri Trounine wrote:
>> Hi Alexander,
>>
>> Thank you much for review. See my comments below:
>>
>> Alexander Alexeev wrote:
>>> Hi Dmitri,
>>>
>>> sorry for delay, the overall changes look good. First, some minor
>>> code's
>>> comments:
>>> 1) Several unused imports and variables in ProvisioningServer.java.
>> Fixed.
>>> 2) DEFAULT_PROVISIONING_HTTP_PORT variable in ExportBundler.java is
>>> never used.
>> Fixed. Using it for settin provisioning.http.port in case it cannot
>> be obtained from JAR URL prefix.
>>> 3) Is it really needed to provide empty classpath in
>>> "dist-provisioning_server.jar" task?
>> Yes, it's required attribute of create_j2se_jar macro. Build fails
>> without it.
>>> 4) provisioningServerMainClass.mf file doesn't contain newline at end.
>>> Some programs treat such files as binary (for example teamware). I
>>> think
>>> it's better to add newline.
>> Fixed.
>>> 5) I noticed you removed dependencies from run tasks. Are they really
>>> don't depend to another tasks now?
>> I've removed dependencies from run-remote and run-test targets. It's
>> made because they are called from 'run' target.
>> They need to be called using 'antcacall' task because they should run
>> in parallel. When target is called using 'antcall' task, all its
>> dependencies are executed, even if they were already executed as
>> dependencies of parent target. As result, if we keep dependencies in
>> 'run-remote' and 'run-test', all dependencies are executed three
>> times! So, I removed dependencies from 'run-test' and 'run-remote'
>> and kept them in 'run'.
>>
>>> 6) Did Stan approved changes in JarBuilder.java?
>> No, changes in JarBuilder is a subject of issue #90, and Stan didn't
>> yet approved it. In fact, after sending this update for review I
>> removed fix of JarBuilder, so that it's now unchanged. You can verify
>> this at the follwoing link which shows the changes made in JarBuilder
>> from the rev. 717 (when the branch was created) to the rev. 789 (HEAD):
>>
>> http://fisheye4.cenqua.com/browse/cqme/branches/users/dtrounine/testExpo...
>>
>>>
>>> Now the runtime comments. I tried the server in work:
>>> 1) "preverify" task fails due to absence of MultiTest.
>> Issue #79: Bad JarBuilder => agent_client.jar is added from within
>> the private methods => no way to catch it and add the sources => no
>> MultiTest => build fails.
>> Beacause of this I needed to apply fix to JarBuilder from another
>> branch and then forgot to remove it. :)
>> If you want to test the runtime, please do the following
>> - checkout branch
>> - apply fix to local workspace:
>> svn merge -r 609:HEAD
>> https://cqme.dev.java.net/svn/cqme/branches/users/dtrounine/testExport/i...
>>
>>> 2) some task requires javatest.jar located in the test suite's lib
>>> directory.
>> This task is 'run-remote'. It starts the remote component in
>> JTHarness in batch mode.
>>> 3) starting of server fails due to absence "provisioning.http.port"
>>> property.
>> User should define this property in build.properties. This will be
>> mentioned in more info for "Jar URL Prefix" question of interview
>> (issue #45 is about updating more info, and i'm working on it).
>> I'll also add a check of this property to build.
>>> 4) the message:
>>> [java] Connection failure. Retrying.
>>> appears during server startup.
>> I've also observed such messages, but they never caused a problem -
>> server starts always. I'll file an issue about this message.
>>
>> Please see new update:
>> http://fisheye4.cenqua.com/changelog/cqme/branches/users/dtrounine/testE...
>>
>>
>> I've also merged latest update from trunk to this branch with some
>> bug fixes (just some useful bugfixes):
>> http://fisheye4.cenqua.com/changelog/cqme/branches/users/dtrounine/testE...
>>
>>
>> Thanks,
>> Dmitri.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
>> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Alexander Alexeev

Hi Dmitri,

OK, I'm fine with this, please do not forget to submit issue on
inappropriate javatest.jar location too.

Thanks,
Alexander

Dmitri Trounine wrote:
> Alexander,
>
> Thanks for review! Let finish with this update :) See my comment below
>
> Alexander Alexeev wrote:
>> Hi Dmitri,
>>
>> I'm OK with code's changes. See some comments below.
>>
>> >> 2) some task requires javatest.jar located in the test suite's lib
>> >> directory.
>> > This task is 'run-remote'. It starts the remote component in JTHarness
>> > in batch mode.
>> I mean javatest.jar is required to be located in test suite's lib dir.
>> Is it possible to require javetest.jar in the lib dir of JTHarness
>> installation?
>> >> 4) the message:
>> >> [java] Connection failure. Retrying.
>> >> appears during server startup.
>> > I've also observed such messages, but they never caused a problem -
>> > server starts always. I'll file an issue about this message.
>> Do we have a short deadline for this feature? If no I think more
>> preferable to fix this issue or find a cause at least.
>>
> Deadline was yesterday. And there are so many issues to fix. While fixes
> are pending, the complexity multiplies. This issue is really not
> critical. I've investigated a little this problem: looks like exception
> is thrown from HttpServer code at startup. May I file a new issue and
> commit?
>
> Thanks,
> Dmitri.
>> Thanks,
>> Alexander
>>
>> Dmitri Trounine wrote:
>>> Hi Alexander,
>>>
>>> Thank you much for review. See my comments below:
>>>
>>> Alexander Alexeev wrote:
>>>> Hi Dmitri,
>>>>
>>>> sorry for delay, the overall changes look good. First, some minor
>>>> code's
>>>> comments:
>>>> 1) Several unused imports and variables in ProvisioningServer.java.
>>> Fixed.
>>>> 2) DEFAULT_PROVISIONING_HTTP_PORT variable in ExportBundler.java is
>>>> never used.
>>> Fixed. Using it for settin provisioning.http.port in case it cannot
>>> be obtained from JAR URL prefix.
>>>> 3) Is it really needed to provide empty classpath in
>>>> "dist-provisioning_server.jar" task?
>>> Yes, it's required attribute of create_j2se_jar macro. Build fails
>>> without it.
>>>> 4) provisioningServerMainClass.mf file doesn't contain newline at end.
>>>> Some programs treat such files as binary (for example teamware). I
>>>> think
>>>> it's better to add newline.
>>> Fixed.
>>>> 5) I noticed you removed dependencies from run tasks. Are they really
>>>> don't depend to another tasks now?
>>> I've removed dependencies from run-remote and run-test targets. It's
>>> made because they are called from 'run' target.
>>> They need to be called using 'antcacall' task because they should run
>>> in parallel. When target is called using 'antcall' task, all its
>>> dependencies are executed, even if they were already executed as
>>> dependencies of parent target. As result, if we keep dependencies in
>>> 'run-remote' and 'run-test', all dependencies are executed three
>>> times! So, I removed dependencies from 'run-test' and 'run-remote'
>>> and kept them in 'run'.
>>>
>>>> 6) Did Stan approved changes in JarBuilder.java?
>>> No, changes in JarBuilder is a subject of issue #90, and Stan didn't
>>> yet approved it. In fact, after sending this update for review I
>>> removed fix of JarBuilder, so that it's now unchanged. You can verify
>>> this at the follwoing link which shows the changes made in JarBuilder
>>> from the rev. 717 (when the branch was created) to the rev. 789 (HEAD):
>>>
>>> http://fisheye4.cenqua.com/browse/cqme/branches/users/dtrounine/testExpo...
>>>
>>>>
>>>> Now the runtime comments. I tried the server in work:
>>>> 1) "preverify" task fails due to absence of MultiTest.
>>> Issue #79: Bad JarBuilder => agent_client.jar is added from within
>>> the private methods => no way to catch it and add the sources => no
>>> MultiTest => build fails.
>>> Beacause of this I needed to apply fix to JarBuilder from another
>>> branch and then forgot to remove it. :)
>>> If you want to test the runtime, please do the following
>>> - checkout branch
>>> - apply fix to local workspace:
>>> svn merge -r 609:HEAD
>>> https://cqme.dev.java.net/svn/cqme/branches/users/dtrounine/testExport/i...
>>>
>>>> 2) some task requires javatest.jar located in the test suite's lib
>>>> directory.
>>> This task is 'run-remote'. It starts the remote component in
>>> JTHarness in batch mode.
>>>> 3) starting of server fails due to absence "provisioning.http.port"
>>>> property.
>>> User should define this property in build.properties. This will be
>>> mentioned in more info for "Jar URL Prefix" question of interview
>>> (issue #45 is about updating more info, and i'm working on it).
>>> I'll also add a check of this property to build.
>>>> 4) the message:
>>>> [java] Connection failure. Retrying.
>>>> appears during server startup.
>>> I've also observed such messages, but they never caused a problem -
>>> server starts always. I'll file an issue about this message.
>>>
>>> Please see new update:
>>> http://fisheye4.cenqua.com/changelog/cqme/branches/users/dtrounine/testE...
>>>
>>>
>>> I've also merged latest update from trunk to this branch with some
>>> bug fixes (just some useful bugfixes):
>>> http://fisheye4.cenqua.com/changelog/cqme/branches/users/dtrounine/testE...
>>>
>>>
>>> Thanks,
>>> Dmitri.
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
>>> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
>> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Vladimir Sizikov

Guys,

On Fri, May 04, 2007 at 01:54:34PM +0400, Alexander Alexeev wrote:
> Hi Dmitri,
>
> OK, I'm fine with this, please do not forget to submit issue on
> inappropriate javatest.jar location too.

With this rate of filing about 3 new bugs for every bugfix we'll end up in
deep trouble! :)

Hopefully, most of the major changes are done by now and we should
strive for source base stabilization. Any new big features should be
postponed for the next releases.

Thanks,
--Vladimir

> Dmitri Trounine wrote:
> >Alexander,
> >
> >Thanks for review! Let finish with this update :) See my comment below
> >
> >Alexander Alexeev wrote:
> >>Hi Dmitri,
> >>
> >>I'm OK with code's changes. See some comments below.
> >>
> >>>> 2) some task requires javatest.jar located in the test suite's lib
> >>>> directory.
> >>> This task is 'run-remote'. It starts the remote component in JTHarness
> >>> in batch mode.
> >>I mean javatest.jar is required to be located in test suite's lib dir.
> >>Is it possible to require javetest.jar in the lib dir of JTHarness
> >>installation?
> >>>> 4) the message:
> >>>> [java] Connection failure. Retrying.
> >>>> appears during server startup.
> >>> I've also observed such messages, but they never caused a problem -
> >>> server starts always. I'll file an issue about this message.
> >>Do we have a short deadline for this feature? If no I think more
> >>preferable to fix this issue or find a cause at least.
> >>
> >Deadline was yesterday. And there are so many issues to fix. While fixes
> >are pending, the complexity multiplies. This issue is really not
> >critical. I've investigated a little this problem: looks like exception
> >is thrown from HttpServer code at startup. May I file a new issue and
> >commit?
> >
> >Thanks,
> > Dmitri.
> >>Thanks,
> >>Alexander
> >>
> >>Dmitri Trounine wrote:
> >>>Hi Alexander,
> >>>
> >>>Thank you much for review. See my comments below:
> >>>
> >>>Alexander Alexeev wrote:
> >>>>Hi Dmitri,
> >>>>
> >>>>sorry for delay, the overall changes look good. First, some minor
> >>>>code's
> >>>>comments:
> >>>>1) Several unused imports and variables in ProvisioningServer.java.
> >>>Fixed.
> >>>>2) DEFAULT_PROVISIONING_HTTP_PORT variable in ExportBundler.java is
> >>>>never used.
> >>>Fixed. Using it for settin provisioning.http.port in case it cannot
> >>>be obtained from JAR URL prefix.
> >>>>3) Is it really needed to provide empty classpath in
> >>>>"dist-provisioning_server.jar" task?
> >>>Yes, it's required attribute of create_j2se_jar macro. Build fails
> >>>without it.
> >>>>4) provisioningServerMainClass.mf file doesn't contain newline at end.
> >>>>Some programs treat such files as binary (for example teamware). I
> >>>>think
> >>>>it's better to add newline.
> >>>Fixed.
> >>>>5) I noticed you removed dependencies from run tasks. Are they really
> >>>>don't depend to another tasks now?
> >>>I've removed dependencies from run-remote and run-test targets. It's
> >>>made because they are called from 'run' target.
> >>>They need to be called using 'antcacall' task because they should run
> >>>in parallel. When target is called using 'antcall' task, all its
> >>>dependencies are executed, even if they were already executed as
> >>>dependencies of parent target. As result, if we keep dependencies in
> >>>'run-remote' and 'run-test', all dependencies are executed three
> >>>times! So, I removed dependencies from 'run-test' and 'run-remote'
> >>>and kept them in 'run'.
> >>>
> >>>>6) Did Stan approved changes in JarBuilder.java?
> >>>No, changes in JarBuilder is a subject of issue #90, and Stan didn't
> >>>yet approved it. In fact, after sending this update for review I
> >>>removed fix of JarBuilder, so that it's now unchanged. You can verify
> >>>this at the follwoing link which shows the changes made in JarBuilder
> >>>from the rev. 717 (when the branch was created) to the rev. 789 (HEAD):
> >>>
> >>>http://fisheye4.cenqua.com/browse/cqme/branches/users/dtrounine/testExport/issue6a/src/share/classes/com/sun/tck/cldc/javatest/util/JarBuilder.java?r1=717&r2=789&u=3&ignore=&k=
> >>>
> >>>>
> >>>>Now the runtime comments. I tried the server in work:
> >>>>1) "preverify" task fails due to absence of MultiTest.
> >>>Issue #79: Bad JarBuilder => agent_client.jar is added from within
> >>>the private methods => no way to catch it and add the sources => no
> >>>MultiTest => build fails.
> >>>Beacause of this I needed to apply fix to JarBuilder from another
> >>>branch and then forgot to remove it. :)
> >>>If you want to test the runtime, please do the following
> >>> - checkout branch
> >>> - apply fix to local workspace:
> >>> svn merge -r 609:HEAD
> >>>https://cqme.dev.java.net/svn/cqme/branches/users/dtrounine/testExport/issue90
> >>>
> >>>>2) some task requires javatest.jar located in the test suite's lib
> >>>>directory.
> >>>This task is 'run-remote'. It starts the remote component in
> >>>JTHarness in batch mode.
> >>>>3) starting of server fails due to absence "provisioning.http.port"
> >>>>property.
> >>>User should define this property in build.properties. This will be
> >>>mentioned in more info for "Jar URL Prefix" question of interview
> >>>(issue #45 is about updating more info, and i'm working on it).
> >>>I'll also add a check of this property to build.
> >>>>4) the message:
> >>>> [java] Connection failure. Retrying.
> >>>>appears during server startup.
> >>>I've also observed such messages, but they never caused a problem -
> >>>server starts always. I'll file an issue about this message.
> >>>
> >>>Please see new update:
> >>>http://fisheye4.cenqua.com/changelog/cqme/branches/users/dtrounine/testExport?cs=790
> >>>
> >>>
> >>>I've also merged latest update from trunk to this branch with some
> >>>bug fixes (just some useful bugfixes):
> >>>http://fisheye4.cenqua.com/changelog/cqme/branches/users/dtrounine/testExport?cs=793
> >>>
> >>>
> >>>Thanks,
> >>> Dmitri.
> >>>
> >>>---------------------------------------------------------------------
> >>>To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> >>>For additional commands, e-mail: meframework-help@cqme.dev.java.net
> >>>
> >>
> >>---------------------------------------------------------------------
> >>To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> >>For additional commands, e-mail: meframework-help@cqme.dev.java.net
> >>
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> >For additional commands, e-mail: meframework-help@cqme.dev.java.net
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Dmitri Trounine

> With this rate of filing about 3 new bugs for every bugfix we'll end up in
> deep trouble! :)
>
>
Filing a bug just means that some work should be done, and it helps to
organize the work. If we don't file new bugs we'll end up faster and in
deeper trouble! :)
> Hopefully, most of the major changes are done by now and we should
> strive for source base stabilization. Any new big features should be
> postponed for the next releases.
>
>
Sure.
> Thanks,
> --Vladimir
>
>
>> Dmitri Trounine wrote:
>>
>>> Alexander,
>>>
>>> Thanks for review! Let finish with this update :) See my comment below
>>>
>>> Alexander Alexeev wrote:
>>>
>>>> Hi Dmitri,
>>>>
>>>> I'm OK with code's changes. See some comments below.
>>>>
>>>>
>>>>>> 2) some task requires javatest.jar located in the test suite's lib
>>>>>> directory.
>>>>>>
>>>>> This task is 'run-remote'. It starts the remote component in JTHarness
>>>>> in batch mode.
>>>>>
>>>> I mean javatest.jar is required to be located in test suite's lib dir.
>>>> Is it possible to require javetest.jar in the lib dir of JTHarness
>>>> installation?
>>>>
>>>>>> 4) the message:
>>>>>> [java] Connection failure. Retrying.
>>>>>> appears during server startup.
>>>>>>
>>>>> I've also observed such messages, but they never caused a problem -
>>>>> server starts always. I'll file an issue about this message.
>>>>>
>>>> Do we have a short deadline for this feature? If no I think more
>>>> preferable to fix this issue or find a cause at least.
>>>>
>>>>
>>> Deadline was yesterday. And there are so many issues to fix. While fixes
>>> are pending, the complexity multiplies. This issue is really not
>>> critical. I've investigated a little this problem: looks like exception
>>> is thrown from HttpServer code at startup. May I file a new issue and
>>> commit?
>>>
>>> Thanks,
>>> Dmitri.
>>>
>>>> Thanks,
>>>> Alexander
>>>>
>>>> Dmitri Trounine wrote:
>>>>
>>>>> Hi Alexander,
>>>>>
>>>>> Thank you much for review. See my comments below:
>>>>>
>>>>> Alexander Alexeev wrote:
>>>>>
>>>>>> Hi Dmitri,
>>>>>>
>>>>>> sorry for delay, the overall changes look good. First, some minor
>>>>>> code's
>>>>>> comments:
>>>>>> 1) Several unused imports and variables in ProvisioningServer.java.
>>>>>>
>>>>> Fixed.
>>>>>
>>>>>> 2) DEFAULT_PROVISIONING_HTTP_PORT variable in ExportBundler.java is
>>>>>> never used.
>>>>>>
>>>>> Fixed. Using it for settin provisioning.http.port in case it cannot
>>>>> be obtained from JAR URL prefix.
>>>>>
>>>>>> 3) Is it really needed to provide empty classpath in
>>>>>> "dist-provisioning_server.jar" task?
>>>>>>
>>>>> Yes, it's required attribute of create_j2se_jar macro. Build fails
>>>>> without it.
>>>>>
>>>>>> 4) provisioningServerMainClass.mf file doesn't contain newline at end.
>>>>>> Some programs treat such files as binary (for example teamware). I
>>>>>> think
>>>>>> it's better to add newline.
>>>>>>
>>>>> Fixed.
>>>>>
>>>>>> 5) I noticed you removed dependencies from run tasks. Are they really
>>>>>> don't depend to another tasks now?
>>>>>>
>>>>> I've removed dependencies from run-remote and run-test targets. It's
>>>>> made because they are called from 'run' target.
>>>>> They need to be called using 'antcacall' task because they should run
>>>>> in parallel. When target is called using 'antcall' task, all its
>>>>> dependencies are executed, even if they were already executed as
>>>>> dependencies of parent target. As result, if we keep dependencies in
>>>>> 'run-remote' and 'run-test', all dependencies are executed three
>>>>> times! So, I removed dependencies from 'run-test' and 'run-remote'
>>>>> and kept them in 'run'.
>>>>>
>>>>>
>>>>>> 6) Did Stan approved changes in JarBuilder.java?
>>>>>>
>>>>> No, changes in JarBuilder is a subject of issue #90, and Stan didn't
>>>>> yet approved it. In fact, after sending this update for review I
>>>>> removed fix of JarBuilder, so that it's now unchanged. You can verify
>>>>> this at the follwoing link which shows the changes made in JarBuilder
>>>>>
>>>> >from the rev. 717 (when the branch was created) to the rev. 789 (HEAD):
>>>>
>>>>> http://fisheye4.cenqua.com/browse/cqme/branches/users/dtrounine/testExpo...
>>>>>
>>>>>
>>>>>> Now the runtime comments. I tried the server in work:
>>>>>> 1) "preverify" task fails due to absence of MultiTest.
>>>>>>
>>>>> Issue #79: Bad JarBuilder => agent_client.jar is added from within
>>>>> the private methods => no way to catch it and add the sources => no
>>>>> MultiTest => build fails.
>>>>> Beacause of this I needed to apply fix to JarBuilder from another
>>>>> branch and then forgot to remove it. :)
>>>>> If you want to test the runtime, please do the following
>>>>> - checkout branch
>>>>> - apply fix to local workspace:
>>>>> svn merge -r 609:HEAD
>>>>> https://cqme.dev.java.net/svn/cqme/branches/users/dtrounine/testExport/i...
>>>>>
>>>>>
>>>>>> 2) some task requires javatest.jar located in the test suite's lib
>>>>>> directory.
>>>>>>
>>>>> This task is 'run-remote'. It starts the remote component in
>>>>> JTHarness in batch mode.
>>>>>
>>>>>> 3) starting of server fails due to absence "provisioning.http.port"
>>>>>> property.
>>>>>>
>>>>> User should define this property in build.properties. This will be
>>>>> mentioned in more info for "Jar URL Prefix" question of interview
>>>>> (issue #45 is about updating more info, and i'm working on it).
>>>>> I'll also add a check of this property to build.
>>>>>
>>>>>> 4) the message:
>>>>>> [java] Connection failure. Retrying.
>>>>>> appears during server startup.
>>>>>>
>>>>> I've also observed such messages, but they never caused a problem -
>>>>> server starts always. I'll file an issue about this message.
>>>>>
>>>>> Please see new update:
>>>>> http://fisheye4.cenqua.com/changelog/cqme/branches/users/dtrounine/testE...
>>>>>
>>>>>
>>>>> I've also merged latest update from trunk to this branch with some
>>>>> bug fixes (just some useful bugfixes):
>>>>> http://fisheye4.cenqua.com/changelog/cqme/branches/users/dtrounine/testE...
>>>>>
>>>>>
>>>>> Thanks,
>>>>> Dmitri.
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
>>>>> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>>>>>
>>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
>>>> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>>>>
>>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
>>> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
>> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Vladimir Sizikov

On Fri, May 04, 2007 at 02:34:21PM +0400, Dmitri Trounine wrote:
> Filing a bug just means that some work should be done, and it helps to
> organize the work. If we don't file new bugs we'll end up faster and in
> deeper trouble! :)

Completely agreed! We should file as much as we can!
And I just filed 7 bugs against the test export. :)

--VVS

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net