Skip to main content

Bugfix for Issue #76: Cannot enable verbose output

2 replies [Last post]
Anonymous

Hi Alexander (Alexeev), team,

Here's another bug related to the verbose output from our
infrastructure:
https://cqme.dev.java.net/issues/show_bug.cgi?id=76
"Cannot enable verbose output for "JavaTest harness" with custom CLDC
channel."

Here's the fix:
http://fisheye4.cenqua.com/changelog/cqme/?cs=544

Basically, the export of "verboseJavaTest" value out of custom cldc
interview was always overridden by export of the same value by base
cldc interview.

Could you please review?

Thanks,
--Vladimir

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Alexander Alexeev

Hi Vladimir,

changes look good. Just one comment. May be remove this line from
export() method of qVerbose?:
data.put("verboseJavaTest", ""+getValue()[1]);

Anyway, please commit. BTW it's interesting that this line is incorrect
by itself - it exports agent verbose answer as value.

Thanks,
Alexander

Vladimir Sizikov wrote:
> Hi Alexander (Alexeev), team,
>
> Here's another bug related to the verbose output from our
> infrastructure:
> https://cqme.dev.java.net/issues/show_bug.cgi?id=76
> "Cannot enable verbose output for "JavaTest harness" with custom CLDC
> channel."
>
> Here's the fix:
> http://fisheye4.cenqua.com/changelog/cqme/?cs=544
>
> Basically, the export of "verboseJavaTest" value out of custom cldc
> interview was always overridden by export of the same value by base
> cldc interview.
>
> Could you please review?
>
> Thanks,
> --Vladimir
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Vladimir Sizikov

Alexander,

Thanks for the quick review!

On Wed, Mar 21, 2007 at 11:25:11PM +0300, Alexander Alexeev wrote:
> changes look good. Just one comment. May be remove this line from
> export() method of qVerbose?:
> data.put("verboseJavaTest", ""+getValue()[1]);

Yes, you're right. I was considering removal of this line but thought
that it would confuse the reviewers... :)

Will remove.

> Anyway, please commit. BTW it's interesting that this line is incorrect
> by itself - it exports agent verbose answer as value.

All the more reasons to remove it!

Thanks,
--Vladimir

> Vladimir Sizikov wrote:
> >Hi Alexander (Alexeev), team,
> >
> >Here's another bug related to the verbose output from our
> >infrastructure:
> >https://cqme.dev.java.net/issues/show_bug.cgi?id=76
> >"Cannot enable verbose output for "JavaTest harness" with custom CLDC
> >channel."
> >
> >Here's the fix:
> >http://fisheye4.cenqua.com/changelog/cqme/?cs=544
> >
> >Basically, the export of "verboseJavaTest" value out of custom cldc
> >interview was always overridden by export of the same value by base
> >cldc interview.
> >
> >Could you please review?
> >
> >Thanks,
> > --Vladimir
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> >For additional commands, e-mail: meframework-help@cqme.dev.java.net
> >
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net