Skip to main content

Please review: Fix for issue #63.

3 replies [Last post]
Anonymous

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Vladimir Sizikov

Dmitri,

The change looks good. I wonder why did you use Vector though...
Vector is, well, outdated and synchronized, and provides less
consistent API then List.

It seems that the standard and clean way is to use List:

Vector libJars = new Vector(); ----->

List libJars = new ArrayList();

What do you think?

Thanks,
--Vladimir

On Tue, Mar 20, 2007 at 12:31:15PM +0300, Dmitri Trounine wrote:
> Hi guys,
>
> I've made fix for issue #63:
> https://cqme.dev.java.net/issues/show_bug.cgi?id=63
>
> Changeset: http://fisheye4.cenqua.com/changelog/cqme?cs=486
>
> Updated sources:
> http://fisheye4.cenqua.com/browse/cqme/branches/users/dtrounine/testExpo...
>
> Please, review.
>
> Thanks,
> Dmitri.
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Dmitri Trounine

Vladimir,

thanks for your comment. Indeed, there is no much sens in using Vector
in this code. It's rather my bad practice, I'll notice this about
Vectors and ArrayLists.

I've fixed this (Do you know why fisheye is often out of sync with our
Subversion repository?):

Index: src/share/classes/com/sun/tck/j2me/javatest/TestExportInfo.java
===================================================================
--- src/share/classes/com/sun/tck/j2me/javatest/TestExportInfo.java
(revision 519)
+++ src/share/classes/com/sun/tck/j2me/javatest/TestExportInfo.java
(revision 520)
@@ -29,7 +29,8 @@

import com.sun.javatest.TestEnvironment;
import java.io.File;
-import java.util.Vector;
+import java.util.ArrayList;
+import java.util.List;

/**
* A class that encapsulates information about test export mode, as
configured
@@ -62,7 +63,7 @@
public static TestExportInfo fromEnv(final TestEnvironment env) {
TestExportInfoImpl info = new TestExportInfoImpl();
String[] envData;
- Vector libJars = new Vector();
+ List libJars = new ArrayList();

try {
// Is export mode enabled?

Thanks,
Dmitri.

Vladimir Sizikov wrote:

>Dmitri,
>
>The change looks good. I wonder why did you use Vector though...
>Vector is, well, outdated and synchronized, and provides less
>consistent API then List.
>
>It seems that the standard and clean way is to use List:
>
>Vector libJars = new Vector(); ----->
>
>List libJars = new ArrayList();
>
>What do you think?
>
>Thanks,
> --Vladimir
>
>On Tue, Mar 20, 2007 at 12:31:15PM +0300, Dmitri Trounine wrote:
>
>
>>Hi guys,
>>
>>I've made fix for issue #63:
>>https://cqme.dev.java.net/issues/show_bug.cgi?id=63
>>
>>Changeset: http://fisheye4.cenqua.com/changelog/cqme?cs=486
>>
>>Updated sources:
>>http://fisheye4.cenqua.com/browse/cqme/branches/users/dtrounine/testExport/issue63
>>
>>Please, review.
>>
>>Thanks,
>> Dmitri.
>>
>>
>>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
>For additional commands, e-mail: meframework-help@cqme.dev.java.net
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Vladimir Sizikov

Dmitri,

On Tue, Mar 20, 2007 at 01:39:58PM +0300, Dmitri Trounine wrote:
> thanks for your comment. Indeed, there is no much sens in using Vector
> in this code. It's rather my bad practice

I have it too. My theory is that we tend to use Vector because
sometimes on Java ME platform the Vector is all thet we can use... :)

> I've fixed this (Do you know why fisheye is often out of sync with our
> Subversion repository?):

Thanks, the fix is good. Please, commit.
As for FishEye, yeah, there is always a delay. Sometimes it's 1-2-5
minutes, and sometimes the web content is not updated for hours.
I asked FishEye folks, they say that there should be no noticeable
delays, so I'm not sure what can we do here.

Thanks,
--Vladimir

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net