Skip to main content

Please review fix for 6477727: synchronised block in NotifySender preventing correct removeAll...

1 reply [Last post]
Anonymous

Hi Vladimir,

please review fix by following link:
http://fisheye4.cenqua.com/changelog/cqme/?cs=507

Now handler.removeAll() is called outside synchronized block and so OTASerer
doesn't block to call synchronized methods.

Thanks,
Alexander

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Vladimir Sizikov

Hi Alexander,

The fix is good. One comment: it makes sense to mark "operation" field
as volatile, since we concurrently mody it in different threads and
it's completely unprotected now (not in sychronized block anymore).

Once you add 'volatile' keyword, pleas commit.

Thanks,
--Vladimir

On Fri, Mar 16, 2007 at 02:58:22PM +0300, Alexander Alexeev wrote:
> Hi Vladimir,
>
> please review fix by following link:
> http://fisheye4.cenqua.com/changelog/cqme/?cs=507
>
> Now handler.removeAll() is called outside synchronized block and so
> OTASerer doesn't block to call synchronized methods.
>
> Thanks,
> Alexander

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net