Skip to main content

Changes in TestBundler class

1 reply [Last post]
Anonymous

Hi Stan,

During my work on test export feature of ME Framework I realized that I
need to make TestBundler class more flexible for reusing its
functionality. Precisely, I want to make some methods protected and add
a number of protected setter and getter methods for private fields:
currentBundle, provider, app, agentArgs, agentJar.

I also propose to move TestResultDispatcher class from TestBundler.java
to separate source file and make it public. This is needed to reuse its
functionality in other components of ME Framework (especially in test
export).

You can take a look at the proposed changes here:

http://fisheye4.cenqua.com/browse/cqme/branches/users/dtrounine/testExpo...
http://fisheye4.cenqua.com/browse/cqme/branches/users/dtrounine/testExpo...

What do you think about it? Can you approve the changes?

Thanks,
Dmitri.

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Mikhail Gorshenev

Hi Dmitry,

I have no problem with exposing the TestBundler methods.
However, given that this is not a trivial API, I would like to
make sure we have detailed javadocs for these methods as well as the new class.

In order to improve the quality of our javadocs, we should only be adding
properly documented APIs.

thanks,
Misha

Dmitri Trounine wrote:
> Hi Stan,
>
> During my work on test export feature of ME Framework I realized that I
> need to make TestBundler class more flexible for reusing its
> functionality. Precisely, I want to make some methods protected and add
> a number of protected setter and getter methods for private fields:
> currentBundle, provider, app, agentArgs, agentJar.
>
> I also propose to move TestResultDispatcher class from TestBundler.java
> to separate source file and make it public. This is needed to reuse its
> functionality in other components of ME Framework (especially in test
> export).
>
> You can take a look at the proposed changes here:
>
> http://fisheye4.cenqua.com/browse/cqme/branches/users/dtrounine/testExpo...
>
> http://fisheye4.cenqua.com/browse/cqme/branches/users/dtrounine/testExpo...
>
>
> What do you think about it? Can you approve the changes?
>
> Thanks,
> Dmitri.
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net