Skip to main content

Review request for ISSUE #42

2 replies [Last post]
Anonymous

Hi Mikhail (Smirnov), team,

Please review the bugfix for
ISSUE #42: J2meBaseTestSuite incorrectly overrides initTestBundler() method

http://fisheye4.cenqua.com/changelog/cqme/?cs=423

Creation of the test bundler in CLDC mode is now delegated to the
CldcTCKBaseTestSuite. Also, some logging added.

Thanks,
--Vladimir

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Mikhail Smirnov

Vladimir,

Fix is OK. Build and unit tests are OK.
I verified that correct bundler is chosen for CLDC, MIDP and Export modes.

Thank you,
Misha

Vladimir Sizikov wrote:
> Hi Mikhail (Smirnov), team,
>
> Please review the bugfix for
> ISSUE #42: J2meBaseTestSuite incorrectly overrides initTestBundler() method
>
> http://fisheye4.cenqua.com/changelog/cqme/?cs=423
>
> Creation of the test bundler in CLDC mode is now delegated to the
> CldcTCKBaseTestSuite. Also, some logging added.
>
> Thanks,
> --Vladimir
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Vladimir Sizikov

Misha,

Thanks a lot for thorough review, the fix has been applied ot both
versions of ME Framework: FW 1.1.2, rev 425, FW 1.2, rev 428.

Thanks,
--Vladimir

On Tue, Mar 06, 2007 at 03:01:35PM +0300, Mikhail Smirnov wrote:
> Vladimir,
>
> Fix is OK. Build and unit tests are OK.
> I verified that correct bundler is chosen for CLDC, MIDP and Export modes.
>
> Thank you,
> Misha
>
> Vladimir Sizikov wrote:
> >Hi Mikhail (Smirnov), team,
> >
> >Please review the bugfix for
> >ISSUE #42: J2meBaseTestSuite incorrectly overrides initTestBundler() method
> >
> >http://fisheye4.cenqua.com/changelog/cqme/?cs=423
> >
> >Creation of the test bundler in CLDC mode is now delegated to the
> >CldcTCKBaseTestSuite. Also, some logging added.
> >
> >Thanks,
> > --Vladimir
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> >For additional commands, e-mail: meframework-help@cqme.dev.java.net
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net