Skip to main content

Please review bugfix for ISSUE #47: Framework interview inconsistencies

2 replies [Last post]
Anonymous

Misha (Smirnov), team,

Please review the following bugfix for ISSUE #47: Framework interview
inconsistencies

http://fisheye4.cenqua.com/changelog/cqme/?cs=395

There were 10 sub-issues listed in the bug report:

1. "Tests in Bundle" question - fixed

2. "Test Export" - was already fixed

3, 10. "TCK-DIRECTORY" vs "TCK-Dir" - were already fixed.
Now we use TCK-Dir consistently, in "More Infos" and in the User
Guides for the recent and upcoming TCKs.

4. "Server Implementation Jar" -> "JAR" - fixed

5. "Client Implementation Jar" -> "JAR" - fixed

6. "Channel Debugging" - is being fixed as part of bugfix for ISSUES 44/46

7. "Base Directory" - the question is exactly as in some of our
already shipped TCKs, and is very, very, very rarely needed to be
changed by users, so I'd prefer to leave it as is rather then
introducing new wording.

8. "Channel Debugging".
I18n strings do not match the more info entries -- Server / Server
(Execution), JavaTest harness / JavaTest harness (TestProvider) pairs

Partially fixed in bugfix for ISSUES 44/46 (removed TestProvider).
I don't think that we have a serious issue here.
We have "Server" checkbox and "Server (Execution)" in More Info.
I consider the (Execution) as sort of additional explanation for
"Server", and I don't think it would confuse anybody.

9. "ContentHandler Implementation Jar" -> "JAR" - fixed

10. see 3.

Thanks,
--Vladimir

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Mikhail Smirnov

Vladimir,

Reviewed. Fix is OK.

Build is OK.
Unit tests are OK.

Thank you,
Misha

Vladimir Sizikov wrote:
> Misha (Smirnov), team,
>
> Please review the following bugfix for ISSUE #47: Framework interview
> inconsistencies
>
> http://fisheye4.cenqua.com/changelog/cqme/?cs=395
>
> There were 10 sub-issues listed in the bug report:
>
> 1. "Tests in Bundle" question - fixed
>
> 2. "Test Export" - was already fixed
>
> 3, 10. "TCK-DIRECTORY" vs "TCK-Dir" - were already fixed.
> Now we use TCK-Dir consistently, in "More Infos" and in the User
> Guides for the recent and upcoming TCKs.
>
> 4. "Server Implementation Jar" -> "JAR" - fixed
>
> 5. "Client Implementation Jar" -> "JAR" - fixed
>
> 6. "Channel Debugging" - is being fixed as part of bugfix for ISSUES 44/46
>
> 7. "Base Directory" - the question is exactly as in some of our
> already shipped TCKs, and is very, very, very rarely needed to be
> changed by users, so I'd prefer to leave it as is rather then
> introducing new wording.
>
> 8. "Channel Debugging".
> I18n strings do not match the more info entries -- Server / Server
> (Execution), JavaTest harness / JavaTest harness (TestProvider) pairs
>
> Partially fixed in bugfix for ISSUES 44/46 (removed TestProvider).
> I don't think that we have a serious issue here.
> We have "Server" checkbox and "Server (Execution)" in More Info.
> I consider the (Execution) as sort of additional explanation for
> "Server", and I don't think it would confuse anybody.
>
> 9. "ContentHandler Implementation Jar" -> "JAR" - fixed
>
> 10. see 3.
>
> Thanks,
> --Vladimir
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Vladimir Sizikov

Misha,

Thanks a lot for fast and thorough reviews and for the test runs, much
appreciated!

--Vladimir

On Thu, Mar 01, 2007 at 04:57:17PM +0300, Mikhail Smirnov wrote:
> Vladimir,
>
> Reviewed. Fix is OK.
>
> Build is OK.
> Unit tests are OK.
>
> Thank you,
> Misha

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net