Skip to main content

Please review fix for 5032102: Need support to use Runtime pack without override installation.

2 replies [Last post]
Anonymous

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Vladimir Sizikov

Hi Alexander,

On Fri, Feb 16, 2007 at 05:00:00PM +0300, Alexander Alexeev wrote:
> I agree with you about adding more dependencies in the code. Unfortunately
> currently I haven't clear ideas how to avoid such dependencies. BTW we need
> access point to the TestSuite since different interviews need access to some
> global properties (as framework location or properties in the jtt file).
> It's possible to create class with static methods special to obtain such
> properties.
> What do you think?

How about the following class that already exists:
com.sun.tck.j2me.J2meTckFrameworkInfo

Maybe it makes sense to add static getMeFwJar() method there?
And since we now have a means to figure out the location of our main
jar file without reading "classpath" entry from the jtt file, this
class can continue to be independent from the TestSuites.

> As for the more flexibility of getMidpAgentJar() I will fix method.
>
> And seems it safe to delete code trying to obtain framework location from
> "classpath" property. Are you agree?

Yes. But let's make sure that the replacement is 100% functional and
works reliably.

Thanks,
--Vladimir

> Vladimir Sizikov wrote:
> >Hi Alexander,
> >
> >The main issue I have with this bugfix is that it introduces
> >additional dependencies between classes that were not dependent
> >before, which makes the whole system more rigid and harder to test in
> >isolation.
> >
> >For example, the base bundling service is now dependent on
> >J2meBaseTestSuite, so it will be hard to test it in isolation.
> >PermissionsInterview is now dependent on VmInterview, TrustedInterview
> >is now dependent on J2meBaseTestSuite (and in the past we tried to
> >eliminate all those direct dependencies between Interview and the
> >TestSuite since they on top of adding unwanted dependencies also
> >introduce tricky hidden bugs).
> >
> >Is there any way to avoid this?
> >
> >Also, CldcBaseCommInterview.getMidpAgentJar() can be a little bit more
> >flexible and could check that the custom provided jar might be in absolute
> >form, and then there is no need to add rootDir + "/lib".
> >
> >Thanks,
> > --Vladimir
> >
> >On Mon, Feb 12, 2007 at 07:29:45PM +0300, Alexander Alexeev wrote:
> >>Hi Vladimir,
> >>
> >>please review fix for 5032102: Need support to use Runtime pack without
> >>override installation.
> >>
> >>The changesets are
> >>http://fisheye4.cenqua.com/changelog/~br=users/cqme/branches/users/skavas/RuntimePack?todate=1171286398508
> >>
> >>See the comments of the commits for details.
> >>
> >>Thanks,
> >>Alexander
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Vladimir Sizikov

Hi Alexander,

I've reviewed the latest changes in your private branch, and I have
only two minor comments:

1. I didn't notice any imports to be removed in the changes classes,
which is strange, we reduced the number of dependencies, and this
should lead to removed imports. Can you double check?

2. The name of the method that returns the FW location is too complex,
just look at the typical use of that method:

J2meTckFrameworkInfo.getJavaMEFrameworkLibDir()
Notice the duplication in the class name and the method name.
Maybe it makes sense to rename it to getFrameworkLibDir?

Once you done with the comments above, please commit.

Thanks,
--Vladimir

On Fri, Feb 16, 2007 at 06:12:49AM -0800, Vladimir Sizikov wrote:
> Hi Alexander,
>
> On Fri, Feb 16, 2007 at 05:00:00PM +0300, Alexander Alexeev wrote:
> > I agree with you about adding more dependencies in the code. Unfortunately
> > currently I haven't clear ideas how to avoid such dependencies. BTW we need
> > access point to the TestSuite since different interviews need access to some
> > global properties (as framework location or properties in the jtt file).
> > It's possible to create class with static methods special to obtain such
> > properties.
> > What do you think?
>
> How about the following class that already exists:
> com.sun.tck.j2me.J2meTckFrameworkInfo
>
> Maybe it makes sense to add static getMeFwJar() method there?
> And since we now have a means to figure out the location of our main
> jar file without reading "classpath" entry from the jtt file, this
> class can continue to be independent from the TestSuites.
>
> > As for the more flexibility of getMidpAgentJar() I will fix method.
> >
> > And seems it safe to delete code trying to obtain framework location from
> > "classpath" property. Are you agree?
>
> Yes. But let's make sure that the replacement is 100% functional and
> works reliably.
>
> Thanks,
> --Vladimir

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net