Skip to main content

Please review fix for 5032102: Need support to use Runtime pack without override installation.

2 replies [Last post]
Anonymous

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Vladimir Sizikov

Hi Alexander,

The main issue I have with this bugfix is that it introduces
additional dependencies between classes that were not dependent
before, which makes the whole system more rigid and harder to test in
isolation.

For example, the base bundling service is now dependent on
J2meBaseTestSuite, so it will be hard to test it in isolation.
PermissionsInterview is now dependent on VmInterview, TrustedInterview
is now dependent on J2meBaseTestSuite (and in the past we tried to
eliminate all those direct dependencies between Interview and the
TestSuite since they on top of adding unwanted dependencies also
introduce tricky hidden bugs).

Is there any way to avoid this?

Also, CldcBaseCommInterview.getMidpAgentJar() can be a little bit more
flexible and could check that the custom provided jar might be in absolute
form, and then there is no need to add rootDir + "/lib".

Thanks,
--Vladimir

On Mon, Feb 12, 2007 at 07:29:45PM +0300, Alexander Alexeev wrote:
> Hi Vladimir,
>
> please review fix for 5032102: Need support to use Runtime pack without
> override installation.
>
> The changesets are
> http://fisheye4.cenqua.com/changelog/~br=users/cqme/branches/users/skava...
>
> See the comments of the commits for details.
>
> Thanks,
> Alexander

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Vladimir Sizikov

Hi Alexander,

I'll review the changes within the next 2-3 days, assuming there will
no high-priority interruptions.

Meanwhile, could you please take a look at Allen's code changes
(common interviews for CDC-stack TCKs). Allen is touching similar
functionality among other things (detection of ME Framework location).

It would be good if you could take a look at Allen's code and you both
could decide whether there is a way not to have this functionality
duplicated, and have Allen's code and your changes to be aligned.

I've reviewed the rest of the Allen's code, so as soon as you are OK
with it, Allen can commit.

Thanks,
--Vladimir

On Mon, Feb 12, 2007 at 07:29:45PM +0300, Alexander Alexeev wrote:
> Hi Vladimir,
>
> please review fix for 5032102: Need support to use Runtime pack without
> override installation.
>
> The changesets are
> http://fisheye4.cenqua.com/changelog/~br=users/cqme/branches/users/skava...
>
> See the comments of the commits for details.
>
> Thanks,
> Alexander

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net