Skip to main content

code review for added interview question

9 replies [Last post]
Anonymous

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
sureshbabu117
Offline
Joined: 2008-03-12

hai Skavas,
plz tel me how to download CLDC-TCK Zip file and also how to login JCP .

vsizikov
Offline
Joined: 2004-11-16

Hi,

> plz tel me how to download CLDC-TCK
> Zip file and also how to login JCP .

The CLDC TCK is available only for Sun's licensees, it is a commercial product and its sources are not generally available (there is a subset of sources shipped with the TCK to simplify the debugging). If your comany is a licensee, you should know where to download the official binaries, on java parter web site.

Thanks,
--Vladimir

Allen Wang

Hi Alexander,

Please review the latest changes.

I changed HostQuestion to allow IP addresses as values because in some
cases, the host may not have a host name. Also, IPv6 addresses may be
used and they have ":" in them which may be rejected by current question.

thanks,
Allen

meframework@mobileandembedded.org wrote:

>Hi Allen,
>
>as was suggested by Vladimir I've started to review your interview changes and have following comments.
>
>1. Why to move CommInterview constants to separate class? Seems they only make sense in CommInterview and so more appropriate to hold them there.
>
>2. Is it really needed to export framework location in DTF interview? It's exported in the MidpTckBaseInterview already. FYI the method returns framework location will be created in the J2meTckFrameworkInfo class in the upcoming changes for the enabling separate framework installation.
>
>3. I've not seen any access points to the new interviews. Is it intentional and TCK's specific interview should create them by itself? I think it possible to detect that TCK need a DTF or sigtest interview and create them from VmInterview.
>
>Thanks,
>Alexander
>[Message sent by forum member 'skavas' (skavas)]
>
>http://forums.java.net/jive/thread.jspa?messageID=204270
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
>For additional commands, e-mail: meframework-help@cqme.dev.java.net
>
>
>

[att1.html]
---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

skavas
Offline
Joined: 2006-10-04

Hi Allen,

just curious if we can provide IP through HostQuestion why we need questions for asking IPs for JavaTest host and passive agent host?

And I think the questions about agent automatic starting and passive agent's host don't make sense in MIDP mode.

Thanks,
Alexander

skavas
Offline
Joined: 2006-10-04

Hi Allen,

as was suggested by Vladimir I've started to review your interview changes and have following comments.

1. Why to move CommInterview constants to separate class? Seems they only make sense in CommInterview and so more appropriate to hold them there.

2. Is it really needed to export framework location in DTF interview? It's exported in the MidpTckBaseInterview already. FYI the method returns framework location will be created in the J2meTckFrameworkInfo class in the upcoming changes for the enabling separate framework installation.

3. I've not seen any access points to the new interviews. Is it intentional and TCK's specific interview should create them by itself? I think it possible to detect that TCK need a DTF or sigtest interview and create them from VmInterview.

Thanks,
Alexander

Allen Wang

Hi Alexander,

Please see my answers below:

meframework@mobileandembedded.org wrote:

>Hi Allen,
>
>as was suggested by Vladimir I've started to review your interview changes and have following comments.
>
>1. Why to move CommInterview constants to separate class? Seems they only make sense in CommInterview and so more appropriate to hold them there.
>
>
To create an instance of DTFInterview, you need to pass in an integer
argument to indicate the mode of interview (CDC or CLDC). This argument
is required to create CommInterview inside DTFInterview. Because reusing
CommInterview is an implementation detail, it would be wrong to expose
the constant values in CommInterview and require client code to
reference it. Therefore, these constant values are moved to a public class.

>2. Is it really needed to export framework location in DTF interview? It's exported in the MidpTckBaseInterview already. FYI the method returns framework location will be created in the J2meTckFrameworkInfo class in the upcoming changes for the enabling separate framework installation.
>
>
OK. I will remove the code to export the framework location.

>3. I've not seen any access points to the new interviews. Is it intentional and TCK's specific interview should create them by itself? I think it possible to detect that TCK need a DTF or sigtest interview and create them from VmInterview.
>
>
No CDC based TCKs use VmInterview. So I think it is best to have the
TCKs create these interviews.

Thanks,
Allen

>Thanks,
>Alexander
>[Message sent by forum member 'skavas' (skavas)]
>
>http://forums.java.net/jive/thread.jspa?messageID=204270
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
>For additional commands, e-mail: meframework-help@cqme.dev.java.net
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

skavas
Offline
Joined: 2006-10-04

Hi Allen,

The creation of CommInterview inside DTFInterview lead to two instances of
CommInterview in CLDC/MIDP mode (one from CldcBaseCommInterview and another from
DTFInterview). It will lead to doubling questions in the interview and I'm not
sure it will work even.
My strong opinion that *ALL* TCKs should use the same base interviews including
VmInterview. This allow to reuse common questions for both modes and to create
all interviews from framework side. BTW as I know there are no CDC-based TCK use
me framework currently (except AGUI but it use VmInterview). All TCKs for
CDC/CLDC optional packages use MidpTckBaseInterview and VmInterview.

Thanks,
Alexander

Vladimir Sizikov

Hi Allen,

Sorry, I wasn't able to fully review your update yet, due to some
high-priority interruptions. To my defense, your code changes are
quite big, and affect our least-structured area, interviews... ;)

I'll finish the review of your code by Wednesday this week.

Hopefully, this does not block you.

Also, I'd suggest that you'd create separate separate branches for
every bugfix, so that you could start working on the new bugfixes
while the old one is being reviewed. The proposed layout would be:

alwang/bugfix1/ (src, doc, unitTests)
alwang/bugfix2/ (src, doc, unitTests)

Typically, there is no need for long-living branches like:
alwang/code

Thanks,
--Vladimir

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

sureshbabu117
Offline
Joined: 2008-03-12

hai ,I am working on CLDC -TCK , for this I need TCK source code if any one knows how to download TCK source code from site.Plz tell me the site name.