Skip to main content

Please review bugfixes for ISSUES #30 and #31

1 reply [Last post]
Anonymous

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Vladimir Sizikov

Hi Allen,

Thanks for the review.
I've incorporated your comments.

Take a look (attached, all the changes in the top two files).

Thanks,
--Vladimir

On Mon, Jan 22, 2007 at 11:55:44AM -0800, Allen Wang wrote:
> Hi Vladimir,
>
> I have two comments:
>
> - In J2meTestBundlingService, the following javadoc is now incorrect
> because getAgentClass() is removed from this class:
>
> /**
> * Constructs class file name from class name as provided by
> * getAgentClass().
> */
> private String getAgentClassName() {
> return agentClass.replace('.', '/')+".class";
> }
>
>
>
> - Another comment:
>
> >Also, Harness.getEnv() is used instead of
> >Harness.getParameters.getEnv(), since we need some values exported in
> >Harness.getEnv().
> >
> The same change should be done for TestSuiteService.getTestEnvironment().
>
> Thanks,
> Allen
[att1.html]
---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net