Skip to main content

JSLEE 1.1 Resource Adaptor Provisioning

6 replies [Last post]
ivelin
Offline
Joined: 2003-07-13
Points: 0

Oleg Kulikov posted a patch for 1.1 style ra config:

> The patch is available as an attachment of the issue #132.
The collection of the configuration properties declared in the resource-adaptor-jar.xml stored in the ResourceAdaptorDescriptorImpl.

Now properties passed to ResourceAdaptorMBean.createResourceAdaptorEntity() will be used to configure RA.

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
fram
Offline
Joined: 2004-05-13
Points: 0

This is indeed a very usefull patch.
Thanks,
Francesco

ivelin
Offline
Joined: 2003-07-13
Points: 0

Oleg, can you please write a test case which shows the new feature against a dummy RA?

For example you can use the http ra, which has no external dependencies:
https://mobicents.dev.java.net/source/browse/mobicents/ra/http-servlet-ra/

Bartek wrote a similar test case to verify the RA event filtering logic on service install, which is another new feature from JSLEE 1.1:
https://mobicents.dev.java.net/source/browse/mobicents/tests/src/org/mob...

kulikoff
Offline
Joined: 2005-11-30
Points: 0

Tests in propgress, just need a bit of time to undersrand testsuite framework. Thanks for references for similar test cases. It is very usefull

ivelin
Offline
Joined: 2003-07-13
Points: 0

It looks good at a first glance.
https://mobicents.dev.java.net/issues/show_bug.cgi?id=132

Several comments:

1 - the source code for the RA was not attached.
2 - the SBB doesn't seem necessary as it doesn't do anything.

some optional things to consider:
3 - the code for installing the RA uses the CLI, which is a little bit of a stretch. There should not be a dependency on environment variable (MOBICENTS_HOME). The setup code will look simpler if it uses SleeBeanShellUtil.deployRa().

Please consider the comments above and proceed with check-in.

Ivelin

kulikoff
Offline
Joined: 2005-11-30
Points: 0

The source code for the RA added, but I still use CLI for test case. This is because the CLI is also involved to process of the RA configuration. CLI is a border of the RA provisioning and I made changes in the CLI too.

ivelin
Offline
Joined: 2003-07-13
Points: 0

looks good. Thanks!