Skip to main content

SwingX build broken ... AGAIN, DAMN!!!!

18 replies [Last post]
Anonymous

Hi guys,

shit happens - but it must not happen every other day.

Some basics (as I see it) to minimize:

* whoever commits has the responsibility to check the build - CC helps a
lot because it will notitfy the committer if anything broke.
* On receiving such a notification, the committer should make it TOP
priority to fix the build. If immediate fix is not possible, the minimum
action should be a notification on the forum, so others don't waste
their time in figureing out what's wrong
* better yet: if a committer can't guarantee to have the time to wait
for build success/failure (after all it's Friday evening), s/he should
wait with the commit until there will be time to cope with the consequences.

This time the first breakage seems to be related to the additions around
MultiGradient, MultiSlider - probably something wrong with the
dependency on the optional jars (which look incomplete anyway,
GroupLayout isn't there).

Jeanette

---------------------------------------------------------------------
To unsubscribe, e-mail: jdnc-unsubscribe@jdnc.dev.java.net
For additional commands, e-mail: jdnc-help@jdnc.dev.java.net

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
neilweber
Offline
Joined: 2003-06-25

Richard,

I see joshy fixed the ASCII/binary status of the jar file. All is well wrt to it.

Neil

Kleopatra

Romain Guy wrote:

Still doesn't compile ... Please, guys - fix it TODAY! Either add the
GroupLayout to the optional jar or (better, because how can we have
dependencies from the mandatory hierarchy to an optional?) move
everything to an optional package or think of another solution - but DO it.

>
> Anyway, Joshua is the culprit, I'll hit him with our giant stuffed
> Tweetie first thing tomorrow morning :)

obviously didn't work . Tell him it's not sufficient to update the
build script if the library is missing.

Jeanette

---------------------------------------------------------------------
To unsubscribe, e-mail: jdnc-unsubscribe@jdnc.dev.java.net
For additional commands, e-mail: jdnc-help@jdnc.dev.java.net

gfx
Offline
Joined: 2003-06-14

Joshua sent me the fixed file and I did the commit for him (some weird network problem on his side.) It *should* work fine by now.

NetBeans users: I had to commit the project files to remove the dependency to GroupLayout so you might have to reconfigure the platform associated to the project. Following what was in the CVS when I did a check out a few weeks ago, the plaform is called "Tiger."

Kleopatra

jdnc-interest@javadesktop.org wrote:
> Joshua sent me the fixed file and I did the commit for him (some weird network problem on his side.) It *should* work fine by now.
>

great! Now we can wait for CC to catch up .. it just did, with an error:

"The following error occurred while executing this line:
/home/virtual/site2/fst/var/www/ROOT/swinglabs/cruisecontrol/projects/swingx-HEAD/swingx/nbproject/build-impl.xml:76:
Platform is not correctly set up"

Locally (I'm compiling in Eclipse, bypassing the build.xml, so am not
effected by any problems there), I still can't compile the latest sources:

"The type GradientThumbRenderer must implement the inherited abstract
method JXMultiThumbSlider.ThumbRenderer.paintThumb(Graphics2D,
JXMultiThumbSlider.ThumbComp, int, boolean)
GradientThumbRenderer.java
jdnc-swingx/src/java/org/jdesktop/swingx/color line 10 22. März 2006
10:43:02"

Any ideas?

Thanks for taking care of it!
Jeanette

---------------------------------------------------------------------
To unsubscribe, e-mail: jdnc-unsubscribe@jdnc.dev.java.net
For additional commands, e-mail: jdnc-help@jdnc.dev.java.net

Romain Guy

The platform thing was my concern. I don't know how CruiseControl is set
up, I guess we need to wait for Frédéric or Richard on this one.

Kleopatra wrote:
> jdnc-interest@javadesktop.org wrote:
>> Joshua sent me the fixed file and I did the commit for him (some weird
>> network problem on his side.) It *should* work fine by now.
>>
>
> great! Now we can wait for CC to catch up .. it just did, with an error:
>
> "The following error occurred while executing this line:
> /home/virtual/site2/fst/var/www/ROOT/swinglabs/cruisecontrol/projects/swingx-HEAD/swingx/nbproject/build-impl.xml:76:
> Platform is not correctly set up"
>
> Locally (I'm compiling in Eclipse, bypassing the build.xml, so am not
> effected by any problems there), I still can't compile the latest sources:
>
> "The type GradientThumbRenderer must implement the inherited abstract
> method JXMultiThumbSlider.ThumbRenderer.paintThumb(Graphics2D,
> JXMultiThumbSlider.ThumbComp, int, boolean)
> GradientThumbRenderer.java
> jdnc-swingx/src/java/org/jdesktop/swingx/color line 10 22. März
> 2006 10:43:02"
>
> Any ideas?
>
> Thanks for taking care of it!
> Jeanette
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jdnc-unsubscribe@jdnc.dev.java.net
> For additional commands, e-mail: jdnc-help@jdnc.dev.java.net
>

--
Romain GUY
http://jroller.com/page/gfx
http://weblogs.java.net/blog/gfx/
http://www.progx.org
http://www.jext.org

---------------------------------------------------------------------
To unsubscribe, e-mail: jdnc-unsubscribe@jdnc.dev.java.net
For additional commands, e-mail: jdnc-help@jdnc.dev.java.net

nicfagn
Offline
Joined: 2003-06-14

> The platform thing was my concern. I don't know how
> CruiseControl is set
> up, I guess we need to wait for Frédéric or Richard
> on this one.
>

It is sufficient to change the platform.active property to default_platform in the project.properties file in nbproject directory:

#platform.active=Tiger
platform.active=default_platform

Obviously, on the system where the project is checked out the default JVM has to be 1.5 or later. But so is how it worked before the last project.properties commit.
To do this from NetBeans 5 ui, you must choose the Java platform marked as default in the Libraries section of the project properties dialog. The other way is to use a text editor. :-)

Nicola Fagnani

neilweber
Offline
Joined: 2003-06-25

I'm getting errors in Eclipse related to MultipleGradientPaints. I added to MultipleGradientPaint.jar to my build path and am still getting the errors. Looking at the jar I see CVS thinks it's an ASCII file and the jar command is unable to list the contents.

Neil

rbair
Offline
Joined: 2003-07-08

What platform are you on Neil?

neilweber
Offline
Joined: 2003-06-25

Richard,

I'm on Windows XP. When I try to list the contents of the jar using Mustang's jar command, I get the following error:

java.lang.IllegalArgumentException
at java.util.zip.ZipInputStream.getUTF8String(ZipInputStream.java:299)
at java.util.zip.ZipInputStream.readLOC(ZipInputStream.java:238)
at java.util.zip.ZipInputStream.getNextEntry(ZipInputStream.java:73)
at sun.tools.jar.Main.list(Main.java:735)
at sun.tools.jar.Main.run(Main.java:191)
at sun.tools.jar.Main.main(Main.java:903)

rbair
Offline
Joined: 2003-07-08

> I'm on Windows XP. When I try to list the contents
> of the jar using Mustang's jar command, I get the
> following error:

That's really strange. I'm not having any problems on either of my XP boxes. The same goes for those icons you reported on last week. I took it up on the NetBeans forums and after getting a littl grief the final diagnosis when I tried again was that they were being added as binary by default (I did a clean checkout on my other machine and they came down fine). I wonder if your CVS client is hashing them?

I have had a problem with jars in the past, but I was coding part-time on Linux.

Richard

elbedr
Offline
Joined: 2003-08-01

Hi,

The build from cruisecontrol has succeeded .. thanks, i am using JXHeader and i ll try to play with JXGraph.

There is one problem that I didnt manage to find the cause in the source : the JXCollapsiblePane.add() shows blank. It s been more than a week or two like that.
Somebody knows why ?

diego@adminsa.com

> Hi,
>
> The build from cruisecontrol has succeeded .. thanks, i am using JXHeader
> and i ll try to play with JXGraph.
>
> There is one problem that I didnt manage to find the cause in the source :
> the JXCollapsiblePane.add() shows blank. It s been more than a week or two
> like that.
> Somebody knows why ?
> [Message sent by forum member 'elbedr' (elbedr)]
>
> http://forums.java.net/jive/thread.jspa?messageID=95940
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jdnc-unsubscribe@jdnc.dev.java.net
> For additional commands, e-mail: jdnc-help@jdnc.dev.java.net
>
>

You must replace JXCollapsiblePane.java with binding branch version. I did
it and works OK. I was trying to see why HEAD version doesn't work and
binding versione does, but still can't figure out.

Diego.

---------------------------------------------------------------------
To unsubscribe, e-mail: jdnc-unsubscribe@jdnc.dev.java.net
For additional commands, e-mail: jdnc-help@jdnc.dev.java.net

rbair
Offline
Joined: 2003-07-08

> You must replace JXCollapsiblePane.java with binding
> branch version. I did
> it and works OK. I was trying to see why HEAD version
> doesn't work and
> binding versione does, but still can't figure out.

Ahhhhhh. The problem appears to be in the constructor. There are two constructors on JXCollapsiblePane, one that takes no arguments and one that takes a layout manager (related to a bug in the issue tracker). The one that takes a layout manager calls "super(layout)" whereas the old one used to call "super.setLayout(layout)". Undoubtedly something related to the wrapper crept in here. I've made the change, and you should now see it working again.

Richard

Romain Guy

Does it build now? I checked out a fresh version a couple of hours ago
and the only problem I noticed was a change in the NetBeans project
related to the current Java Platform. Other than that it builds fine.

Anyway, Joshua is the culprit, I'll hit him with our giant stuffed
Tweetie first thing tomorrow morning :)

Kleopatra wrote:
>
> Hi guys,
>
> shit happens - but it must not happen every other day.
>
> Some basics (as I see it) to minimize:
>
> * whoever commits has the responsibility to check the build - CC helps a
> lot because it will notitfy the committer if anything broke.
> * On receiving such a notification, the committer should make it TOP
> priority to fix the build. If immediate fix is not possible, the minimum
> action should be a notification on the forum, so others don't waste
> their time in figureing out what's wrong
> * better yet: if a committer can't guarantee to have the time to wait
> for build success/failure (after all it's Friday evening), s/he should
> wait with the commit until there will be time to cope with the
> consequences.
>
> This time the first breakage seems to be related to the additions around
> MultiGradient, MultiSlider - probably something wrong with the
> dependency on the optional jars (which look incomplete anyway,
> GroupLayout isn't there).
>
> Jeanette
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jdnc-unsubscribe@jdnc.dev.java.net
> For additional commands, e-mail: jdnc-help@jdnc.dev.java.net
>

--
Romain GUY
http://jroller.com/page/gfx
http://weblogs.java.net/blog/gfx/
http://www.progx.org
http://www.jext.org

---------------------------------------------------------------------
To unsubscribe, e-mail: jdnc-unsubscribe@jdnc.dev.java.net
For additional commands, e-mail: jdnc-help@jdnc.dev.java.net

Kleopatra

Romain Guy wrote:
> Does it build now?

CruiseControl says "failed":

http://www.javadesktop.org/cruisecontrol/index.jsp

> I checked out a fresh version a couple of hours ago
> and the only problem I noticed was a change in the NetBeans project
> related to the current Java Platform. Other than that it builds fine.
>

no, it still doesn't - Grouplayout is missing (or I didn't find it).
Looks like your local workspace is different from the cvs. To test for
a clean build you need to do a clean checkout - or look onto the CC
page, which does it for us ;.)

> Anyway, Joshua is the culprit, I'll hit him with our giant stuffed
> Tweetie first thing tomorrow morning :)
>

Jeanette

---------------------------------------------------------------------
To unsubscribe, e-mail: jdnc-unsubscribe@jdnc.dev.java.net
For additional commands, e-mail: jdnc-help@jdnc.dev.java.net

Romain Guy

I just did a clean checkout/clean and build. I am using NetBeans 5.0 to
compile SwingX and GroupLayout is included in NetBeans. Is that what you
are using? Anyway, CC is certainly not running with GroupLayout in its
classpath.

I guess the best thing to do right now is to back out JXGradientChooser
and wait for Joshua to rewrite it with standard layouts or reconfigure
CC. But I think there should be some discussion first to see whether or
not GroupLayout is an acceptable dependency for SwingX (GroupLayout.jar
is 160kB large and has recently been integrated into Java SE 6 but with
a different package name.)

Kleopatra wrote:
> Romain Guy wrote:
>> Does it build now?
>
> CruiseControl says "failed":
>
> http://www.javadesktop.org/cruisecontrol/index.jsp
>
>
>> I checked out a fresh version a couple of hours ago and the only
>> problem I noticed was a change in the NetBeans project related to the
>> current Java Platform. Other than that it builds fine.
>>
>
> no, it still doesn't - Grouplayout is missing (or I didn't find it).
> Looks like your local workspace is different from the cvs. To test for a
> clean build you need to do a clean checkout - or look onto the CC page,
> which does it for us ;.)
>
>> Anyway, Joshua is the culprit, I'll hit him with our giant stuffed
>> Tweetie first thing tomorrow morning :)
>>
>
>
>
> Jeanette
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jdnc-unsubscribe@jdnc.dev.java.net
> For additional commands, e-mail: jdnc-help@jdnc.dev.java.net
>

--
Romain GUY
http://jroller.com/page/gfx
http://weblogs.java.net/blog/gfx/
http://www.progx.org
http://www.jext.org

---------------------------------------------------------------------
To unsubscribe, e-mail: jdnc-unsubscribe@jdnc.dev.java.net
For additional commands, e-mail: jdnc-help@jdnc.dev.java.net

Kleopatra

Romain Guy wrote:
> I just did a clean checkout/clean and build. I am using NetBeans 5.0 to
> compile SwingX and GroupLayout is included in NetBeans. Is that what you
> are using? Anyway, CC is certainly not running with GroupLayout in its
> classpath.
>

ahh, now I understand why you Netbeans guys never see if GroupLayout is
missing - but you can't assume that everybody else is using it, so for
the general case it's a must to include the jar, as optional or
mandatory lib - no hard opinion about that.

Jeanette

---------------------------------------------------------------------
To unsubscribe, e-mail: jdnc-unsubscribe@jdnc.dev.java.net
For additional commands, e-mail: jdnc-help@jdnc.dev.java.net

Romain Guy

I know, that's why I'm saying we should back out the component so that
the CVS can be built again until we decide what to do with GroupLayout.

Kleopatra wrote:
> Romain Guy wrote:
>> I just did a clean checkout/clean and build. I am using NetBeans 5.0
>> to compile SwingX and GroupLayout is included in NetBeans. Is that
>> what you are using? Anyway, CC is certainly not running with
>> GroupLayout in its classpath.
>>
>
> ahh, now I understand why you Netbeans guys never see if GroupLayout is
> missing - but you can't assume that everybody else is using it, so for
> the general case it's a must to include the jar, as optional or
> mandatory lib - no hard opinion about that.
>
> Jeanette
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jdnc-unsubscribe@jdnc.dev.java.net
> For additional commands, e-mail: jdnc-help@jdnc.dev.java.net
>

--
Romain GUY
http://jroller.com/page/gfx
http://weblogs.java.net/blog/gfx/
http://www.progx.org
http://www.jext.org

---------------------------------------------------------------------
To unsubscribe, e-mail: jdnc-unsubscribe@jdnc.dev.java.net
For additional commands, e-mail: jdnc-help@jdnc.dev.java.net