Skip to main content

Build problems with user names

1 reply [Last post]
rogerhernandez
Offline
Joined: 2005-02-23

I ran into two build problems because my user name has a space in it:

1) In Sanity.gmk, in the check for the unicows.lib size:
if [ ! "$(shell $(LS) -l $(UNICOWS_LIB_PATH)/unicows.lib | $(NAWK) '{print $$5;}')" = \
Had to change '{print $$5;}' to '{print $$6;}'. The script should probably use 'echo $(USERNAME) | wc -w' to set the size offset.

2) In hotspot-rules.gmk, building the hotspot compilers:
$(NMAKE) -f $(HOTSPOT_BUILD_DIR)/build.make Variant=compiler1 \
WorkSpace=$(ABS_HOTSPOT_TOPDIR) BootStrapDir=$(subst /,\\,$(BOOTDIR)) \
BuildUser=$(USERNAME) $(HOTSPOT_BUILD_ARGS) \
Had to change BuildUser=$(USERNAME) to BuildUser="$(USERNAME)".

Roger Hernandez

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
kellyohair
Offline
Joined: 2004-09-03

> I ran into two build problems because my user name
> has a space in it:
>
> 1) In Sanity.gmk, in the check for the unicows.lib
> size:
> if [ ! "$(shell $(LS) -l
> l $(LS) -l $(UNICOWS_LIB_PATH)/unicows.lib | $(NAWK)
> '{print $$5;}')" = \
> Had to change '{print $$5;}' to '{print $$6;}'. The
> script should probably use 'echo $(USERNAME) | wc -w'
> to set the size offset.

This will be fixed in B42 bug 6260873.
I changed it to use wc -c.
Turns out that using positions like this was a problem in non-English locales too, so I've been trying to make these sanity checks more generic.

>
> 2) In hotspot-rules.gmk, building the hotspot
> compilers:
> $(NMAKE) -f $(HOTSPOT_BUILD_DIR)/build.make
> ake Variant=compiler1 \
> WorkSpace=$(ABS_HOTSPOT_TOPDIR)
> R) BootStrapDir=$(subst /,\\,$(BOOTDIR)) \
> BuildUser=$(USERNAME) $(HOTSPOT_BUILD_ARGS) \
> Had to change BuildUser=$(USERNAME) to
> BuildUser="$(USERNAME)".

Looks like bug 6204119 covers this problem, I'll add some information to it and see if we can't fix this soon.

Thanks for posting this.

-kto